Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpv1: Exercise HoldTime in Test_NeighborAddDel #25760

Merged
merged 1 commit into from May 30, 2023

Conversation

rastislavs
Copy link
Contributor

Enhances Test_NeighborAddDel to exercise the HoldTime configuration. As HoldTime is negotiated with the peer, we can verify that the value applied on the peer side matches our value, given that we use a value lower than the default HoldTime (90s).

Enhances Test_NeighborAddDel to exercise the HoldTime configuration.
As HoldTime is negotiated with the peer, we can verify that the value
applied on the peer side matches our value, given that we use
a value lower than the default HoldTime (90s).

Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
@rastislavs rastislavs added release-note/ci This PR makes changes to the CI. area/bgp labels May 30, 2023
@rastislavs rastislavs marked this pull request as ready for review May 30, 2023 12:21
@rastislavs rastislavs requested a review from a team as a code owner May 30, 2023 12:21
@rastislavs
Copy link
Contributor Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 30, 2023
@dylandreimerink dylandreimerink merged commit a93bc8a into cilium:main May 30, 2023
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bgp ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants