docs: Deprecate cluster-pool-v2beta
#25767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandro
added
area/documentation
christarazi
approved these changes
May 31, 2023
|
/test Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.25-kernel-4.19/255/ If it is a flake and a GitHub issue doesn't already exist to track it, comment Then please upload the Jenkins artifacts to that issue. |
|
CI failure looks like #25785 |
|
/test-1.25-4.19 |
gandro
added
the
release-blocker/1.14
|
CI was green. Unfortunately this needs a rebase now. |
The `cluster-pool-v2beta` IPAM mode has been added in Cilium v1.12 as a preview feature. Since then, we have added a more flexible `multi-pool` IPAM mode, which addresses some of the shortcomings of `cluster-pool-v2`. Mainly, `multi-pool` supports multiple pod CIDR pools, it has a simpler CIDR release mechanism, and it allows users to specify what IP pool a certain pod should allocate from via pod annotation. Therefore, since `cluster-pool-v2beta` was never made generally available and was never recommended for production (and indeed still has a few known limitations and bugs), we therefore deprecate it in v1.14, with the plan to remove it in v1.15. The only `cluster-pool-v2beta` feature that is lacking in `multi-pool` IPAM mode is BGP support. We intend to add BGP support to multi-pool IPAM in Cilium v1.15. This commit also hides a few mentions of the `cluster-pool-v2beta` mode from the command-line help page. This does not impact any functional behavior. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
force-pushed
the
pr/gandro/deprecate-cluster-pool-v2beta
branch
from
67e67ad
to
6f2fe9e
Compare
|
/test Job 'Cilium-PR-K8s-1.16-kernel-4.19' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.16-kernel-4.19/461/ If it is a flake and a GitHub issue doesn't already exist to track it, comment Then please upload the Jenkins artifacts to that issue. |
|
/test-1.16-4.19 |
zacharysarah
approved these changes
Jun 7, 2023
Comment on lines
+362
to
+363
| The functionality to dynamically allocate Pod CIDRs is now provided by the | ||
| more flexible ``multi-pool`` IPAM mode. |
There was a problem hiding this comment.
Edits for clarity
Suggested change
| The functionality to dynamically allocate Pod CIDRs is now provided by the | |
| more flexible ``multi-pool`` IPAM mode. | |
| Dynamic allocation of Pod CIDRs is now provided by the | |
| more flexible ``multi-pool`` IPAM mode. |
maintainer-s-little-helper
bot
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cluster-pool-v2betaIPAM mode has been added in Cilium v1.12 as a preview feature. Since then, we have added a more flexiblemulti-poolIPAM mode (c.f. #22762), which addresses some of the shortcomings ofcluster-pool-v2. Mainly,multi-poolsupports multiple pod CIDR pools, it has a simpler CIDR release mechanism, and it allows users to specify what IP pool a certain pod should allocate from via pod annotation.Therefore, since
cluster-pool-v2betawas never made generally available and was never recommended for production (and indeed still has a few known limitations and bugs that make it unlikely it has been deployed in production), we therefore deprecate it in v1.14, with the plan to remove it in v1.15.The only
cluster-pool-v2betafeature that is lacking inmulti-poolIPAM mode is BGP support. We intend to add BGP support to multi-pool IPAM in Cilium v1.15.This PR also hides a few mentions of the
cluster-pool-v2betamode from the command-line help page. This does not impact any functional behavior.