Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgp,test: Properly wait for FRR container to be ready #25777

Merged
merged 1 commit into from Jun 5, 2023
Merged

bgp,test: Properly wait for FRR container to be ready #25777

merged 1 commit into from Jun 5, 2023

Conversation

YutaroHayakawa
Copy link
Member

Please see commit message for more details.

bgp,test: Properly wait for FRR container to be ready

@YutaroHayakawa YutaroHayakawa added kind/bug/CI This is a bug in the testing code. release-note/ci This PR makes changes to the CI. labels May 31, 2023
@YutaroHayakawa YutaroHayakawa mentioned this pull request May 31, 2023
Merged
@YutaroHayakawa YutaroHayakawa force-pushed the yutaro/wait-frr-properly-in-bgp-test branch from d23e332 to bfc7175 Compare May 31, 2023 03:54
@YutaroHayakawa YutaroHayakawa marked this pull request as ready for review May 31, 2023 04:39
@YutaroHayakawa YutaroHayakawa requested review from a team as code owners May 31, 2023 04:39
@YutaroHayakawa
Copy link
Member Author

YutaroHayakawa commented May 31, 2023 •
edited by maintainer-s-little-helper bot

/test

Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed:

Click to show.

Test Name

K8sUpdates Tests upgrade and downgrade from a Cilium stable image to master

Failure Output

FAIL: Unexpected missed tail calls

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/304/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.26-kernel-net-next so I can create one.

Then please upload the Jenkins artifacts to that issue.

viktor-kurchenko
viktor-kurchenko reviewed May 31, 2023
View reviewed changes
test/k8s/bgp.go Outdated Show resolved Hide resolved
@YutaroHayakawa YutaroHayakawa force-pushed the yutaro/wait-frr-properly-in-bgp-test branch from bfc7175 to ffe2cea Compare June 1, 2023 08:44
@YutaroHayakawa
Copy link
Member Author

YutaroHayakawa commented Jun 1, 2023 •
edited by maintainer-s-little-helper bot

/test

Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks N/S loadbalancing Tests with XDP, direct routing, DSR with Geneve and Maglev

Failure Output

FAIL: Can not connect to service "http://[fd04::11]:30263" from outside cluster (1/10)

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/360/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.26-kernel-net-next so I can create one.

Then please upload the Jenkins artifacts to that issue.

@YutaroHayakawa
Copy link
Member Author

YutaroHayakawa commented Jun 2, 2023 •
edited

Need to rebase to get #24422 to resolve net-next failure.

@YutaroHayakawa
bgp,test: Properly wait for FRR container to be ready
a755523 
PodIP will be assigned even if the containers are not ready. Don't
waiting for the actual readiness state here causes unexpected error in
the later test case. For example, when FRR container is not brought up
with image pull failure, the later "Connectivity to endpoint via LB"
test fails because no one installs the route to the kernel FIB.

Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
@YutaroHayakawa YutaroHayakawa force-pushed the yutaro/wait-frr-properly-in-bgp-test branch from ffe2cea to a755523 Compare June 2, 2023 08:42
@YutaroHayakawa
Copy link
Member Author

/test

@YutaroHayakawa
Copy link
Member Author

Cilium Runtime: I triggered this CI too early before finishing to build the images. Rerunning.

@YutaroHayakawa
Copy link
Member Author

All unexecuted tests are skipped because this PR only contains the changes under test/. Ready to merge.

@YutaroHayakawa YutaroHayakawa added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 5, 2023
@borkmann borkmann merged commit cb19fd2 into cilium:main Jun 5, 2023
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylandreimerink dylandreimerink dylandreimerink approved these changes

@viktor-kurchenko viktor-kurchenko viktor-kurchenko approved these changes

Assignees
No one assigned
Labels
kind/bug/CI This is a bug in the testing code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YutaroHayakawa @dylandreimerink @viktor-kurchenko @borkmann