Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for XFRM config removal #25793

Closed
pchaigno opened this issue May 31, 2023 · 1 comment · Fixed by #27187 or #27212
Closed

Unit tests for XFRM config removal #25793

pchaigno opened this issue May 31, 2023 · 1 comment · Fixed by #27187 or #27212
Assignees
@pchaigno
Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS.

Comments

@pchaigno
Copy link
Member

We should extend the IPsec unit tests to prevent #25784 from happening again. We probably need to make sure that they cover both cluster-pool & co. IPAMs as well as Azure & ENI IPAMs. The latter are probably not covered today and there are still small differences in the way we handle these two groups of IPAM modes.
@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. labels May 31, 2023
@pchaigno pchaigno self-assigned this May 31, 2023
@pchaigno pchaigno linked a pull request Aug 2, 2023 that will close this issue
node: Integration test for XFRM leaks on node churn #27187
Merged
@pchaigno
Copy link
Member Author

pchaigno commented Aug 2, 2023

This is now covered for cluster-pool & co. IPAM modes, with #27187.

@pchaigno pchaigno linked a pull request Aug 2, 2023 that will close this issue
datapath: Cover subnet encryption in XFRM leak test #27212
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pchaigno pchaigno

Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS.
Projects
None yet
Milestone
No milestone
1 participant
@pchaigno