Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add JUnit reports upload #25801

Merged
merged 1 commit into from Jun 5, 2023
Merged

Conversation

brlbil
Copy link
Contributor

@brlbil brlbil commented May 31, 2023

This PR adds the generation and uploading of connectivity test Junit reports.
In order the distinguish Junit reports in CI reporting two metadata items are added to the reports.

workflow shows the workflow it was run on, and type indicates the configuration of the cilium installation.

Workflows run results:
conformance-aks-v1.12.yaml
conformance-aks-v1.13.yaml
conformance-aws-cni-v1.11.yaml Cilium installation failed, not related to these changes
conformance-aws-cni-v1.12.yaml Cilium installation failed, not related to these changes
conformance-aws-cni-v1.13.yaml
conformance-aws-cni.yaml
conformance-clustermesh-v1.11.yaml
conformance-clustermesh-v1.12.yaml One of the connectivity tests failed. It shows the failure correctly in the summary.
conformance-clustermesh-v1.13.yaml
conformance-clustermesh.yaml
conformance-e2e-v1.13.yaml
conformance-e2e.yaml One of the connectivity tests failed. It shows the failure correctly in the summary.
conformance-eks-v1.11.yaml
conformance-eks-v1.12.yaml Test exceeded the run time, so it is canceled. No reports were generated.
conformance-eks-v1.13.yaml
conformance-eks.yaml
conformance-externalworkloads-v1.11.yaml
conformance-externalworkloads-v1.12.yaml
conformance-externalworkloads-v1.13.yaml
conformance-externalworkloads.yaml
conformance-gke-v1.11.yaml
conformance-gke-v1.12.yaml
conformance-gke-v1.13.yaml
conformance-gke.yaml
conformance-kind-proxy-daemonset.yaml
conformance-multicluster-v1.11.yaml
conformance-multicluster-v1.12.yaml
conformance-multicluster-v1.13.yaml

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 31, 2023
@brlbil brlbil force-pushed the pr/brlbil/ci-add-junit-uploads branch 2 times, most recently from ee0cd4d to fb1576f Compare June 1, 2023 09:38
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 1, 2023
@brlbil brlbil force-pushed the pr/brlbil/ci-add-junit-uploads branch from fb1576f to 7f27c89 Compare June 1, 2023 11:10
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 1, 2023
@cilium cilium deleted a comment from maintainer-s-little-helper bot Jun 1, 2023
@brlbil brlbil added area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels Jun 1, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 1, 2023
@brlbil brlbil force-pushed the pr/brlbil/ci-add-junit-uploads branch 2 times, most recently from 6fdc51a to a4f14fd Compare June 2, 2023 11:39
@brlbil brlbil requested a review from aanm June 2, 2023 13:05
@brlbil brlbil marked this pull request as ready for review June 2, 2023 13:05
@brlbil brlbil requested review from a team as code owners June 2, 2023 13:05
@brlbil brlbil requested a review from nebril June 2, 2023 13:05
@brlbil brlbil force-pushed the pr/brlbil/ci-add-junit-uploads branch 2 times, most recently from 9b4c4d1 to f4c3ae3 Compare June 2, 2023 14:30
This commit adds `--junit-file` and two `--junit-property` flags to
connectivity tests. JUnit properties are workflow and type.
The `type` property is set according to test parameters so Junit reports
can be distinguished in reporting.

Also, it fixes cilium-sysdump upload artifact in GKE
workflows which currently is generating more than one artifact.

Signed-off-by: Birol Bilgin <birol@cilium.io>
@brlbil brlbil force-pushed the pr/brlbil/ci-add-junit-uploads branch 2 times, most recently from 46113db to 9da3e44 Compare June 2, 2023 17:01
@brlbil
Copy link
Contributor Author

brlbil commented Jun 5, 2023

Reviews are in and the failing test is unrelated, so setting it as ready-to-merge

@brlbil brlbil added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 5, 2023
@dylandreimerink dylandreimerink merged commit 12d7643 into main Jun 5, 2023
48 checks passed
@dylandreimerink dylandreimerink deleted the pr/brlbil/ci-add-junit-uploads branch June 5, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants