Increase the max wait time for EndpointCreate API requests #25805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeed
added
area/cni
|
/test |
thorn3r
approved these changes
Jun 2, 2023
squeed
force-pushed
the
endpointcreate-wait-longer
branch
from
5a9f0af
to
cd0b6d9
Compare
|
/test |
christarazi
added
kind/enhancement
In the event that a node has a burst of PodSanboxCreate requests, API requests will pile up. However, we should wait longer for the queue to clear before short-circuting and returing failure. This is because the kubelet has a relatively relaxed timeout for PodSandbox creation -- 4 minutes. Furthermore, if we return a failure here, it is propagated all the way back through containerd to kubelet, which will tear down the entire PodSandbox and try again, which can be expensive. So, increase the maximum queue duration time to 1 minute. That should hopefully give enough time for the queue to clear. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
squeed
force-pushed
the
endpointcreate-wait-longer
branch
from
cd0b6d9
to
4ff1ef8
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
With regards to feature freeze, I argue this is fixing a known bug (and it tweaks a few configs, rather than introducing any sort of new behavior). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event that a node has a burst of PodSanboxCreate requests, API requests will pile up. However, we should wait longer for the queue to clear before short-circuting and returing failure.
This is because the kubelet has a relatively relaxed timeout for PodSandbox creation -- 4 minutes. Furthermore, if we return a failure here, it is propagated all the way back through containerd to kubelet, which will tear down the entire PodSandbox and try again, which can be expensive.
So, increase the maximum queue duration time to 1 minute. That should hopefully give enough time for the queue to clear.
Fixes: #24361