Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renovate: do not update 'github.com/mdlayher/arp' #25807

Merged
merged 1 commit into from Jun 1, 2023

Conversation

aanm
Copy link
Member

@aanm aanm commented May 31, 2023

We are still using an old version of this dependency in github.com/cilium/metallb so we should avoid updating it in the meanwhile.

It will fix PR #25539

We are still using an old version of this dependency in
github.com/cilium/metallb so we should avoid updating it in the
meanwhile.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. dependencies Pull requests that update a dependency file labels May 31, 2023
@aanm aanm requested a review from a team as a code owner May 31, 2023 23:11
@aanm aanm requested a review from bimmlerd May 31, 2023 23:11
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

magical

@@ -125,6 +125,8 @@
// want to update them automatically.
"go.universe.tf/metallb",
"github.com/cilium/metallb",
// metallb is still using an old version of "github.com/mdlayher/arp"
"github.com/mdlayher/arp",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also track the work to get back to being able to update this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, created #25814

@aanm aanm merged commit 5bbdb83 into cilium:main Jun 1, 2023
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake dependencies Pull requests that update a dependency file release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants