Makefile: use CLI options to set local images for kind-install-cilium-clustermesh #25810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
…mesh `make-kind-clustermesh-images` uses `KIND_ENV` to set image repositories for local images to be pushed to kind clusters, however these are not actually used when installing Cilium on the kind clusters in `kind-install-cilium-clustermesh`. The hardcoded image overrides have been removed from the helm values for these clusters and replaced with CLI flags to specify using the local images for Agent and Operator. Signed-off-by: Tim Horner <timothy.horner@isovalent.com>
thorn3r
force-pushed
the
kindClustermeshImages
branch
from
4dbe1fc
to
c9f538a
Compare
thorn3r
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
borkmann
approved these changes
Jun 8, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile: use CLI options to set local images for kind-install-cilium-clustermesh
make-kind-clustermesh-imagesusesKIND_ENVto set image repositories for local images to be pushed to kind clusters, however these are not actually used when installing Cilium on the kind clusters inkind-install-cilium-clustermesh.The hardcoded image overrides have been removed from the helm values for these clusters and replaced with CLI flags to specify using the local images for Agent and Operator.
Fixes: #issue-number