Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gha: Move to helm mode for aws-cni, eks, gke #25820

Merged
merged 3 commits into from Jun 2, 2023
Merged

gha: Move to helm mode for aws-cni, eks, gke #25820

merged 3 commits into from Jun 2, 2023

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Jun 1, 2023 •
edited

Description

Please refer to individual commits for more details.

Relates: #25156

Testing

Testing was done with the temp commit, please find below the successful runs for each job:

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 1, 2023
@sayboras sayboras added the release-note/ci This PR makes changes to the CI. label Jun 1, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 1, 2023
@sayboras
gha: Move to helm mode for aws-cni
942ec51 
Relates: #25156
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
gha: Move to helm mode for aws-eks
1cfea47 
Relates: #25156
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
gha: Move to helm mode for gke
1207fe0 
Relates: #25156
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras changed the title Tam/helm mode gha gha: Move to helm mode for aws-cni, eks, gke Jun 1, 2023
@sayboras sayboras changed the title gha: Move to helm mode for aws-cni, eks, gke gha: Move to helm mode for aks, aws-cni, eks, gke Jun 1, 2023
@sayboras sayboras force-pushed the tam/helm-mode-gha branch 2 times, most recently from 85f85a3 to 1207fe0 Compare June 1, 2023 12:09
@sayboras sayboras marked this pull request as ready for review June 1, 2023 12:09
@sayboras sayboras requested review from a team as code owners June 1, 2023 12:09
@sayboras sayboras requested a review from nbusseneau June 1, 2023 12:09
@sayboras sayboras mentioned this pull request Jun 1, 2023
Closed
15 tasks
@sayboras sayboras changed the title gha: Move to helm mode for aks, aws-cni, eks, gke gha: Move to helm mode for aws-cni, eks, gke Jun 1, 2023
brb
brb approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

nbusseneau
nbusseneau approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@nbusseneau nbusseneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tl;dr

@sayboras
Copy link
Member Author

sayboras commented Jun 1, 2023

Required reviews are in, changes are limited to GHA, full CI is not required. Marking this ready to merge.

@sayboras sayboras added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 1, 2023
@sayboras
Copy link
Member Author

sayboras commented Jun 2, 2023

/test

@sayboras sayboras merged commit 96685b3 into main Jun 2, 2023
61 checks passed
@sayboras sayboras deleted the tam/helm-mode-gha branch June 2, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

@nbusseneau nbusseneau nbusseneau approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sayboras @brb @nbusseneau