Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for release v1.14.0-snapshot.3 #25830

Merged
merged 3 commits into from Jun 1, 2023
Merged

Prepare for release v1.14.0-snapshot.3 #25830

merged 3 commits into from Jun 1, 2023

Conversation

aanm
Copy link
Member

@aanm aanm commented Jun 1, 2023

See the included CHANGELOG.md for a full list of changes.

@aanm aanm requested review from a team as code owners June 1, 2023 14:28
@aanm aanm added the kind/release Used for a PR that releases a new Cilium version. label Jun 1, 2023
@aanm aanm requested review from joamaki and sayboras June 1, 2023 14:28
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 1, 2023
@aanm aanm requested a review from qmonnet June 1, 2023 14:28
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Jun 1, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 1, 2023
@julianwiedmann
Copy link
Member

Comparing to #25206, there's quite a few differences in the changed files (looking at register.go and the helm-values.rst). Is everything there as expected?

aanm added 3 commits June 1, 2023 17:16
@aanm
update AUTHORS and Documentation
6312196 
Signed-off-by: André Martins <andre@cilium.io>
@aanm
Prepare for release v1.14.0-snapshot.3
ba9a248 
Signed-off-by: André Martins <andre@cilium.io>
@aanm
Revert "Prepare for release v1.14.0-snapshot.3"
d1b5e52 
This reverts commit ba9a248.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/prepare-v1.14.0-snapshot.3 branch from 78734fa to d1b5e52 Compare June 1, 2023 15:16
@aanm
Copy link
Member Author

aanm commented Jun 1, 2023

Comparing to #25206, there's quite a few differences in the changed files (looking at register.go and the helm-values.rst). Is everything there as expected?

Thank you for double checking. The register.go was automatically updated because the schema must have changed since snapshot.2. But the helm-values.rst was indeed not expected!

julianwiedmann
julianwiedmann approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Maybe give the CI a minute, I think it had actually noticed the helm-values.rst change.

@aanm aanm merged commit a68ea40 into cilium:main Jun 1, 2023
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianwiedmann julianwiedmann julianwiedmann approved these changes

@joamaki joamaki Awaiting requested review from joamaki joamaki is a code owner automatically assigned from cilium/sig-k8s

@sayboras sayboras Awaiting requested review from sayboras sayboras was automatically assigned from cilium/helm

@qmonnet qmonnet Awaiting requested review from qmonnet qmonnet is a code owner automatically assigned from cilium/docs-structure

Assignees
No one assigned
Labels
kind/release Used for a PR that releases a new Cilium version. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanm @julianwiedmann