Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: use Cilium CLI Helm mode for conformance-clustermesh #25834

Merged
merged 1 commit into from Jun 6, 2023

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Jun 1, 2023

Let's convert the conformance-clustermesh workflow to leverage the new Helm mode of the Cilium CLI. Both hubble and clustermesh are now enabled at install time, to configure the image versions and speedup the whole process.

The connect operation is still performed with the legacy approach, but the new helm mode will be automatically used once cilium/cilium-cli#1628 gets merged and released.

Link to successful run: https://github.com/cilium/cilium/actions/runs/5174733271?pr=25834

Related: #25156

gha: use Cilium CLI Helm mode for conformance-clustermesh 

@giorio94 giorio94 added area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/ci This PR makes changes to the CI. labels Jun 1, 2023
Let's convert the conformance-clustermesh workflow to leverage the new
Helm mode of the Cilium CLI. Both hubble and clustermesh are now enabled
at install time, to configure the image versions and speedup the whole
process.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 force-pushed the pr/giorio94/conformance-clustermesh-helm branch 2 times, most recently from 23e6ae3 to 852efdb Compare June 5, 2023 08:32
@giorio94
Copy link
Member Author

giorio94 commented Jun 5, 2023

Last run completed successfully. I've dropped the temporary test commit, and I'm marking this PR as ready for review.

@giorio94 giorio94 marked this pull request as ready for review June 5, 2023 08:34
@giorio94 giorio94 requested review from a team as code owners June 5, 2023 08:34
@giorio94 giorio94 requested review from brlbil and asauber June 5, 2023 08:34
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

magical

@giorio94
Copy link
Member Author

giorio94 commented Jun 6, 2023

Reviews are in, and this PR modifies only one GitHub Actions workflow. Marking as ready to merge without running the additional tests.

@giorio94 giorio94 added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 6, 2023
@dylandreimerink dylandreimerink merged commit 81a6e10 into main Jun 6, 2023
49 checks passed
@dylandreimerink dylandreimerink deleted the pr/giorio94/conformance-clustermesh-helm branch June 6, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants