New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add microsoft as user to cilium #25838
Add microsoft as user to cilium #25838
Conversation
Commits 77ed1a3f804072a2ed3fcebf336171918cfed975, 8980dc5358ba21f54c1eb07975e871cdd009bd54 do not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Thanks for the addition! Note you will need to sign off and squash the commits as per the above message. |
8980dc5
to
b3f8a5e
Compare
Commit 77ed1a3f804072a2ed3fcebf336171918cfed975 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
b3f8a5e
to
721fd52
Compare
Thanks for the addition @tamilmani1989! Can you also put it in alphabetical order? |
0e2aab2
to
ba4a01b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
updated in alphabetical order Signed-off-by: Tamilmani Manoharan <tamanoha@microsoft.com>
ba4a01b
to
2bf9396
Compare
@xmulligan @pchaigno can you help with merge if there are no other concerns? |
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes: <commit-id>
tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Fixes: #issue-number