Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add microsoft as user to cilium #25838

Merged

Conversation

tamilmani1989
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #issue-number

<!-- Enter the release note text here if needed or remove this section! -->

@tamilmani1989 tamilmani1989 requested a review from a team as a code owner June 1, 2023 19:58
@maintainer-s-little-helper
Copy link

Commits 77ed1a3f804072a2ed3fcebf336171918cfed975, 8980dc5358ba21f54c1eb07975e871cdd009bd54 do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 1, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jun 1, 2023
@pchaigno pchaigno added the release-note/misc This PR makes changes that have no direct user impact. label Jun 1, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 1, 2023
@pchaigno
Copy link
Member

pchaigno commented Jun 1, 2023

Thanks for the addition!

Note you will need to sign off and squash the commits as per the above message.

@tamilmani1989 tamilmani1989 force-pushed the tamilmani1989/addUserMicrosoft branch from 8980dc5 to b3f8a5e Compare June 1, 2023 21:51
@maintainer-s-little-helper
Copy link

Commit 77ed1a3f804072a2ed3fcebf336171918cfed975 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@tamilmani1989 tamilmani1989 force-pushed the tamilmani1989/addUserMicrosoft branch from b3f8a5e to 721fd52 Compare June 1, 2023 22:22
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 1, 2023
@xmulligan
Copy link
Member

Thanks for the addition @tamilmani1989! Can you also put it in alphabetical order?

@tklauser tklauser requested a review from xmulligan June 2, 2023 08:51
@tamilmani1989 tamilmani1989 force-pushed the tamilmani1989/addUserMicrosoft branch 3 times, most recently from 0e2aab2 to ba4a01b Compare June 2, 2023 16:33
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

updated in alphabetical order
Signed-off-by: Tamilmani Manoharan <tamanoha@microsoft.com>
@tamilmani1989 tamilmani1989 force-pushed the tamilmani1989/addUserMicrosoft branch from ba4a01b to 2bf9396 Compare June 5, 2023 17:32
@tamilmani1989
Copy link
Contributor Author

@xmulligan @pchaigno can you help with merge if there are no other concerns?

@xmulligan xmulligan added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 6, 2023
@dylandreimerink dylandreimerink merged commit 0991c6d into cilium:main Jun 6, 2023
13 checks passed
@tamilmani1989 tamilmani1989 deleted the tamilmani1989/addUserMicrosoft branch June 6, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants