Makefile: Fix kind deployment in quiet mode #25873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
added
the
release-note/misc
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
|
Heads up @chancez just FYI |
The "$(QUIET)" directive is a Makefile syntax converting to something like "@" when env V=0, so as a Makefile directive it must be at the beginning of the line, or "make kind" will fail. Fix it. CC: Chance Zibolski <chance.zibolski@gmail.com> Fixes: cb2b112 ("Set SED binary from Makefile in kind.sh") Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
pr/joe/fix-kind-target
branch
from
3ef3ff9
to
ac6d3dc
Compare
chancez
approved these changes
Jun 6, 2023
borkmann
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "$(QUIET)" directive is a Makefile syntax converting to something
like "@" when env V=0, so as a Makefile directive it must be at the
beginning of the line, or "make kind" will fail. Fix it.
Fixes: cb2b112 ("Set SED binary from Makefile in kind.sh")