Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BGP CP: Updates docs for PeerPort #25876

Merged
merged 1 commit into from Jun 14, 2023
Merged

BGP CP: Updates docs for PeerPort #25876

merged 1 commit into from Jun 14, 2023

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Jun 2, 2023

Updates BGP CP docs for the newly added PeerPort field of CiliumBGPPeeringPolicy.

Requires: #25809
Fixes: #25869

@danehans
BGP CP: Updates docs for PeerPort
50a97a4 
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
@danehans danehans requested review from a team as code owners June 2, 2023 22:50
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 2, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jun 2, 2023
@danehans
Copy link
Contributor Author

danehans commented Jun 2, 2023

cc: @rastislavs @harsimran-pabla @YutaroHayakawa

@qmonnet qmonnet added dont-merge/blocked Another PR must be merged before this one. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Jun 5, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 5, 2023
@qmonnet
Copy link
Member

qmonnet commented Jun 7, 2023

I'm switching this PR to draft status until the blocking PR has been merged.

@qmonnet qmonnet marked this pull request as draft June 7, 2023 10:27
@danehans danehans marked this pull request as ready for review June 13, 2023 15:41
@danehans
Copy link
Contributor Author

@qmonnet the required PR has merged so this one's ready for review. cc: @rastislavs @harsimran-pabla @YutaroHayakawa

@qmonnet qmonnet removed the dont-merge/blocked Another PR must be merged before this one. label Jun 13, 2023
qmonnet
qmonnet approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rastislavs
Copy link
Contributor

rastislavs commented Jun 13, 2023 •
edited

Docs change only, docs & netlify builds successful - marking as ready to merge. Thanks!

@rastislavs rastislavs added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 13, 2023
@joestringer joestringer merged commit f51e68d into cilium:main Jun 14, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rastislavs rastislavs rastislavs approved these changes

@qmonnet qmonnet qmonnet approved these changes

@dylandreimerink dylandreimerink Awaiting requested review from dylandreimerink dylandreimerink is a code owner automatically assigned from cilium/sig-bgp

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BGP CP: Document PeerPort
4 participants
@danehans @qmonnet @rastislavs @joestringer