bpf: minor HostFW cleanups #25881
Merged
bpf: minor HostFW cleanups #25881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combine some ENABLE_HOST_FIREWALL sections, and limit the definition of relevant variables. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
cil_to_netdev() only uses the `proto` variable when the hostFW is enabled. handle_to_netdev_ipv6() is already wrapped in ENABLE_HOST_FIREWALL, no need to also check it inside the function. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
added
sig/datapath
This feels rather bogus, the .node_port flag should only ever be used by the nodeport code. We can also trust that ct_buffer.ct_state.node_port is never actually set: - the callers of ipv*_host_policy_ingress_lookup() 0-initialize the whole ct_buffer struct, and - the CT lookup returned CT_NEW, thus ct_buffer.ct_state is unchanged. So just remove this code. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
force-pushed
the
1.14-bpf-hostfw
branch
from
fdb449e
to
278ca25
Compare
|
/test |
gentoo-root
requested changes
Jun 5, 2023
| from_host_raw = ctx_load_meta(ctx, CB_FROM_HOST); | ||
| ctx_store_meta(ctx, CB_FROM_HOST, 0); | ||
| #endif /* ENABLE_HOST_FIREWALL */ | ||
|
|
There was a problem hiding this comment.
I believe we want this block to be above any potential early return, so that we don't leak any non-zero metadata.
There was a problem hiding this comment.
But the only preceding return is a drop?
There was a problem hiding this comment.
Well, yes, I guess it should be safe then.
I was under impression we try to clear metadata the first thing in the function for extra robustness, but it doesn't look problematic in this case.
| from_host_raw = ctx_load_meta(ctx, CB_FROM_HOST); | ||
| ctx_store_meta(ctx, CB_FROM_HOST, 0); | ||
| #endif /* ENABLE_HOST_FIREWALL */ | ||
|
|
gentoo-root
approved these changes
Jun 5, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some innocent cleanups from poking around in the HostFW paths.