Gateway API: Implement generic route checks #25885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyskens
added
dont-merge/preview-only
meyskens
force-pushed
the
meyskens/refactor-gateway
branch
2 times, most recently
from
5745d95
to
0a189e1
Compare
meyskens
force-pushed
the
meyskens/refactor-gateway
branch
3 times, most recently
from
d265a18
to
27dbc33
Compare
meyskens
added
area/servicemesh
meyskens
force-pushed
the
meyskens/refactor-gateway
branch
from
27dbc33
to
db143d8
Compare
|
/test |
meyskens
force-pushed
the
meyskens/refactor-gateway
branch
from
db143d8
to
a1e52af
Compare
|
/test |
meyskens
force-pushed
the
meyskens/refactor-gateway
branch
from
a1e52af
to
7952386
Compare
|
/test |
youngnick
approved these changes
Jun 26, 2023
This refactors the Gateway API code to re-use the route checks functions into a separate package with route checks which can be used for any Gateway API route type. This allows for easier code re-use for later route implementations as well as better readability. Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
meyskens
force-pushed
the
meyskens/refactor-gateway
branch
from
7952386
to
73acf3d
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
sayboras
added
backport/author
sayboras
added
backport-pending/1.14
sayboras
changed the title
sayboras
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the Gateway API code to re-use the route checks functions
into a separate package with route checks which can be used for any Gateway API route type.
This allows for easier code re-use for later route implementations as well as better readability.
Fixes: #25130
Blocked as needed changes from #25711