Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clustermesh-apiserver: write synced information into etcd #25905

Merged
merged 1 commit into from Jun 6, 2023
Merged

clustermesh-apiserver: write synced information into etcd #25905

merged 1 commit into from Jun 6, 2023

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Jun 5, 2023

This PR includes the glue logic to introduce the support of per-prefix "synced" canaries in the clustermesh-apiserver. This enables remote watchers understand that the initial synchronization has completed, and it is possible to retrieve an up-to-date state.

Related: #25388

clustermesh-apiserver: expose information about completion of initial synchronization through etcd

@giorio94
clustermesh-apiserver: write synced information into etcd
5156311 
This commit includes the glue logic to introduce the support of
per-prefix "synced" canaries in the clustermesh-apiserver. This
enables remote watchers understand that the initial synchronization
has completed, and it is possible to retrieve an up-to-date state.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/clustermesh Relates to multi-cluster routing functionality in Cilium. sig/kvstore Impacts the KVStore package interactions. labels Jun 5, 2023
@giorio94 giorio94 requested a review from a team as a code owner June 5, 2023 13:05
@giorio94
Copy link
Member Author

giorio94 commented Jun 5, 2023

/test

YutaroHayakawa
YutaroHayakawa approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@giorio94
Copy link
Member Author

giorio94 commented Jun 6, 2023

Conformance ClusterMesh hit known flake #25816. Rerunning manually.

@giorio94
Copy link
Member Author

giorio94 commented Jun 6, 2023 •
edited

/ci-gke

Failed when creating the GKE cluster: #25918

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 6, 2023
@dylandreimerink dylandreimerink merged commit eb05ecc into cilium:main Jun 6, 2023
62 checks passed
@marseel marseel mentioned this pull request Jun 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

Assignees
No one assigned
Labels
area/clustermesh Relates to multi-cluster routing functionality in Cilium. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/kvstore Impacts the KVStore package interactions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@giorio94 @YutaroHayakawa @dylandreimerink