Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpv1: graceful restart component test #25914

Merged
merged 1 commit into from Jun 7, 2023
Merged

bgpv1: graceful restart component test #25914

merged 1 commit into from Jun 7, 2023

Conversation

harsimran-pabla
Copy link
Contributor

Added component test for BGP graceful restart configuration knobs and corresponding get peer state validation.

@harsimran-pabla harsimran-pabla added release-note/misc This PR makes changes that have no direct user impact. area/bgp labels Jun 5, 2023
@harsimran-pabla harsimran-pabla requested a review from a team as a code owner June 5, 2023 20:26
ldelossa
ldelossa approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rastislavs
rastislavs approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harsimran-pabla
Copy link
Contributor Author

/test

@harsimran-pabla
bgpv1: graceful restart component test
4518fd7 
Added component test for bgp graceful restart configuration knobs and
corresponding get peer state validation.

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
@harsimran-pabla
Copy link
Contributor Author

ConformanceK8sKind test failed, opened CI issue for it : #25951

@harsimran-pabla
Copy link
Contributor Author

/test

@harsimran-pabla
Copy link
Contributor Author

Runtime test failing due to #25939

[2023-06-06T21:17:43.076Z]   	 [21:17:29] --- FAIL: Test (14.47s)
[2023-06-06T21:17:43.076Z]   	 [21:17:29]   --- FAIL: Test/LoaderTestSuite (14.42s)
[2023-06-06T21:17:43.076Z]   	 [21:17:29]     --- FAIL: Test/LoaderTestSuite/TestCompileAndLoadDefaultEndpoint (10.00s)
[2023-06-06T21:17:43.076Z]   	 [21:17:29] 
[2023-06-06T21:17:43.076Z]   	 [21:17:29] level=info msg="Using autogenerated IPv4 allocation range" subsys=node v4Prefix=10.1.0.0/16
[2023-06-06T21:17:43.076Z]   	 [21:17:29] level=info msg="Using autogenerated IPv6 allocation range" subsys=node v6Prefix="f00d::a01:0:0:0/96"
[2023-06-06T21:17:43.076Z]   	 [21:17:29] level=error msg="Command execution failed" cmd="[llc -march=bpf -mcpu=v3 -filetype=obj -o /tmp/cilium_3710055089/bpf_lxc.o]" error="signal: killed" subsys=datapath-loader
[2023-06-06T21:17:43.076Z]   	 [21:17:29] level=error msg="Failed to compile bpf_lxc.o: Command execution failed for [llc -march=bpf -mcpu=v3 -filetype=obj -o /tmp/cilium_3710055089/bpf_lxc.o]: context deadline exceeded" compiler-pid=58702 linker-pid=58703 subsys=datapath-loader
[2023-06-06T21:17:43.076Z]   	 [21:17:29] level=warning msg="JoinEP: Failed to compile" debug=true error="Failed to compile bpf_lxc.o: Command execution failed for [llc -march=bpf -mcpu=v3 -filetype=obj -o /tmp/cilium_3710055089/bpf_lxc.o]: context deadline exceeded" params="&{Source:bpf_lxc.c Output:bpf_lxc.o OutputType:obj Options:[]}" subsys=testutils
[2023-06-06T21:17:43.076Z]   	 [21:17:29]     loader_test.go:158: 
[2023-06-06T21:17:43.076Z]   	 [21:17:29]         ... value *fmt.wrapError = &fmt.wrapError{msg:"Failed to compile bpf_lxc.o: Command execution failed for [llc -march=bpf -mcpu=v3 -filetype=obj -o /tmp/cilium_3710055089/bpf_lxc.o]: context deadline exceeded", err:(*fmt.wrapError)(0xc0001e2200)} ("Failed to compile bpf_lxc.o: Command execution failed for [llc -march=bpf -mcpu=v3 -filetype=obj -o /tmp/cilium_3710055089/bpf_lxc.o]: context deadline exceeded")

@harsimran-pabla
Copy link
Contributor Author

/test-runtime

@rastislavs rastislavs added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 7, 2023
@dylandreimerink dylandreimerink merged commit fa85a7f into cilium:main Jun 7, 2023
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldelossa ldelossa ldelossa approved these changes

@rastislavs rastislavs rastislavs approved these changes

Assignees
No one assigned
Labels
area/bgp ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@harsimran-pabla @ldelossa @rastislavs @dylandreimerink