Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformance-k8s-kind: Use Helm mode cilium-cli #25916

Merged
merged 1 commit into from Jun 6, 2023
Merged

Conversation

michi-covalent
Copy link
Contributor

.github/workflows/conformance-k8s-kind.yaml Show resolved Hide resolved
@@ -26,6 +26,7 @@ env:
# renovate: datasource=github-releases depName=cilium/cilium-cli
cilium_cli_version: v0.14.5
cilium_cli_ci_version:
CILIUM_CLI_MODE: helm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually try with global env like this, but i faced a couple of issue like flag abc is not supported for cilium cli command (other than cilium install), not sure if it works here, and for all cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah let's see if i'm lucky enough.

@michi-covalent
Copy link
Contributor Author

/test

@michi-covalent michi-covalent marked this pull request as ready for review June 6, 2023 03:30
@michi-covalent michi-covalent requested review from a team as code owners June 6, 2023 03:30
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@michi-covalent michi-covalent merged commit 2d1f68c into main Jun 6, 2023
61 checks passed
@michi-covalent michi-covalent deleted the pr/michi/kind branch June 6, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants