Add gARP capability to L2 announcer feature #25933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylandreimerink
added
kind/enhancement
dylandreimerink
force-pushed
the
feature/l2-announcement-garp
branch
from
7cc36ed
to
7f7daf8
Compare
The garp package was sending out ARP requests, while valid in some situations, what we actually need is to send out ARP replies which tell nodes on the network what the new MAC address is for a given IP instead of asking the nodes. This commit also changes the `SendOnInterface` to `SendOnInterfaceIdx` since the only call site for this function has indices not names available. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
When failover occurs a different node will start responding to ARP. But other nodes on the network will not know this has happened and thus keep using the ARP entry from their local cache. This commit makes it so we broadcast a gARP reply with the new MAC address of the IP any time we reconcile a IP+ifidx tuple that was not yet present in the L2 responder map. Nodes that honor gARP replies will update their ARP cache to minimize downtime. Those who do not honer these replies will have more downtime until their ARP cache entry expires and they perform a ARP request themselves. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
dylandreimerink
force-pushed
the
feature/l2-announcement-garp
branch
from
7f7daf8
to
92e24f2
Compare
|
/test Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/517/ If it is a flake and a GitHub issue doesn't already exist to track it, comment Then please upload the Jenkins artifacts to that issue. |
|
/test-1.26-net-next |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When failover occurs a different node will start responding to ARP.
But other nodes on the network will not know this has happened and thus
keep using the ARP entry from their local cache.
This PR makes it so we broadcast a gARP reply with the new MAC
address of the IP any time we reconcile a IP+ifidx tuple that was not
yet present in the L2 responder map.
Nodes that honor gARP replies will update their ARP cache to minimize
downtime. Those who do not honer these replies will have more downtime
until their ARP cache entry expires and they perform a ARP request
themselves.