Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to GOPATH in documentation #25942

Merged
merged 1 commit into from Jun 7, 2023
Merged

Remove references to GOPATH in documentation #25942

merged 1 commit into from Jun 7, 2023

Conversation

JamesLaverack
Copy link
Member

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

It is no longer nessicary to build or develop Cilium from your GOPATH, and any directory can be used.

@JamesLaverack JamesLaverack requested review from a team as code owners June 6, 2023 13:46
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 6, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jun 6, 2023
bimmlerd
bimmlerd approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@bimmlerd bimmlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Jun 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 6, 2023
@JamesLaverack
Remove references to GOPATH in documentation
f1c4c49 
It is no longer nessicary to build or develop Cilium from your GOPATH,
and any directory can be used.

Signed-off-by: James Laverack <james@isovalent.com>
qmonnet
qmonnet approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@JamesLaverack
Copy link
Member Author

JamesLaverack commented Jun 6, 2023 •
edited

Gonna mention this at the community meeting tomorrow (Tuesday Wednesday 7th June 2023).

@qmonnet
Copy link
Member

qmonnet commented Jun 6, 2023

That's what I was about to write :)
Looks all in order for merging if the community agrees on it.

@qmonnet
Copy link
Member

qmonnet commented Jun 6, 2023

Tomorrow might be Wednesday, though.

@JamesLaverack
Copy link
Member Author

Tomorrow might be Wednesday, though.

Whoops. 🙃

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 7, 2023
@qmonnet
Copy link
Member

qmonnet commented Jun 7, 2023

Ready to merge, as per consensus at the meeting

@dylandreimerink dylandreimerink merged commit 63db66a into cilium:main Jun 7, 2023
36 checks passed
@JamesLaverack JamesLaverack mentioned this pull request Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bimmlerd bimmlerd bimmlerd approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JamesLaverack @qmonnet @bimmlerd @dylandreimerink