Fix and improve Conformance Ginkgo UX #25950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
area/misc
In order for needs.*.outputs.* work, the job needs to depend on the job that is being checked. Fixes: 79e1c31 (".github: add missing job to check for code changes") Signed-off-by: André Martins <andre@cilium.io>
To be consistent with other workflows that use matrixes, conformance-e2e.yaml, we should also report the workflow status in a similar way. Signed-off-by: André Martins <andre@cilium.io>
aanm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for needs..outputs. work, the job needs to depend on the job that is being checked.
Fixes: 79e1c31 (".github: add missing job to check for code changes")