Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpv1: Documentation update to reflect current architecture #25954

Merged
merged 1 commit into from Jun 14, 2023

Conversation

harsimran-pabla
Copy link
Contributor

Updating BGP documentation to match refactor done in #25016.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 6, 2023
@harsimran-pabla harsimran-pabla added area/bgp release-note/misc This PR makes changes that have no direct user impact. labels Jun 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 6, 2023
@harsimran-pabla harsimran-pabla force-pushed the hpabla/bgp-documentation branch 2 times, most recently from 4b0cdd6 to 1717ac1 Compare June 9, 2023 13:51
@harsimran-pabla harsimran-pabla marked this pull request as ready for review June 9, 2023 13:52
@harsimran-pabla harsimran-pabla requested review from a team as code owners June 9, 2023 13:52
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good overall, with some comments below.

Documentation/network/bgp-control-plane.rst Outdated Show resolved Hide resolved
Documentation/network/bgp-control-plane.rst Outdated Show resolved Hide resolved
Documentation/network/bgp-control-plane.rst Outdated Show resolved Hide resolved
Documentation/network/bgp-control-plane.rst Outdated Show resolved Hide resolved
Documentation/network/bgp-control-plane.rst Outdated Show resolved Hide resolved
Documentation/network/bgp-control-plane.rst Outdated Show resolved Hide resolved
Updating BGP documentation to match refactor done in cilium#25016.

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harsimran-pabla
Copy link
Contributor Author

Documentation change only, relevant docs tests passed and reviews completed. Marking ready-to-merge manually.

@harsimran-pabla harsimran-pabla added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 9, 2023
@joestringer joestringer merged commit 42099b8 into cilium:main Jun 14, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bgp ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants