docs: Add externalTrafficPolicy=Local description to BGP CPlane doc #25960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
YutaroHayakawa
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
YutaroHayakawa
force-pushed
the
yutaro/bgp-cplane-etp-local/doc
branch
from
654cc6d
to
854d267
Compare
qmonnet
approved these changes
Jun 7, 2023
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| When the service has ``externalTrafficPolicy: Local``, ``BGP Control Plane`` keeps track | ||
| of the endpoints for the service on the local node and stop advertisement when there's |
There was a problem hiding this comment.
Suggested change
| of the endpoints for the service on the local node and stop advertisement when there's | |
| of the endpoints for the service on the local node and stops advertisement when there's |
As we now implemented the support for externalTrafficPolicy in 24e37ed. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa
force-pushed
the
yutaro/bgp-cplane-etp-local/doc
branch
from
854d267
to
e696c41
Compare
|
Reviews are in and base CIs are passing. Since this is a docs-only change, I won't run full CI. |
YutaroHayakawa
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we now implemented the support for externalTrafficPolicy in 24e37ed.