auth: streamline logging #25965
Merged
auth: streamline logging #25965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofstetter
added
kind/cleanup
mhofstetter
force-pushed
the
pr/mhofstetter/auth-logger
branch
from
55f56a3
to
96e6fd8
Compare
|
|
mhofstetter
force-pushed
the
pr/mhofstetter/auth-logger
branch
from
96e6fd8
to
0dee078
Compare
|
rebased to |
Currently package auth is using a package global defined logger. Hive provides the possibility to have a logger injected, which provides the context of the hive module. This way refactors all occurrences to use the injected logger by configuring all components accordingly. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
This commit renames the auth module' id from `auth-manager` to `auth`. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
This commit adjusts the log messages by using fields for providing context and by removing the prefix `auth: ` which is redundant to the logger' subsystem. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
This commit adjusts the log messages by using fields for providing context. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
force-pushed
the
pr/mhofstetter/auth-logger
branch
from
0dee078
to
7e0b8a5
Compare
|
rebased to |
|
/test |
|
ci-ginkgo testrun failed with #25964 -> won't retry because it's not required |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR streamlines logging within the auth package.
auth:from the message itself (which is a duplicate of the fieldsubsys)For more detail - have a look at the individual commits.