Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpv1: Extend the timeout for the Test_NeighborAddDel test #25970

Merged
merged 1 commit into from Jun 7, 2023

Conversation

rastislavs
Copy link
Contributor

@rastislavs rastislavs commented Jun 7, 2023

After the recent GoBGP version upgrade the Test_NeighborAddDel test takes a bit longer than it used to.

Still analyzing why exactly, but extending the timeout to 1 min should be enough to avoid CI issues.

Fixes: #25968

After the recent GoBGP version upgrade the Test_NeighborAddDel
test takes a bit longer than it used to.

Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 7, 2023
@rastislavs rastislavs added area/CI Continuous Integration testing issue or flake ci/flake This is a known failure that occurs in the tree. Please investigate me! area/bgp release-note/ci This PR makes changes to the CI. labels Jun 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 7, 2023
@rastislavs rastislavs marked this pull request as ready for review June 7, 2023 09:06
@rastislavs rastislavs requested a review from a team as a code owner June 7, 2023 09:06
@rastislavs
Copy link
Contributor Author

rastislavs commented Jun 7, 2023

/test

Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed:

Click to show.

Test Name

K8sDatapathConfig Iptables Skip conntrack for pod traffic

Failure Output

FAIL: Found 4 k8s-app=cilium logs matching list of errors that must be investigated:

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/551/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.26-kernel-net-next so I can create one.

Then please upload the Jenkins artifacts to that issue.

Copy link
Contributor

@harsimran-pabla harsimran-pabla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we should look to consolidate neighbor timers - graceful restart test also creates 1 min test duration var.

If it is short term only, we can leave it as is till we figure out why suddenly test is taking approx 45s.

@qmonnet
Copy link
Member

qmonnet commented Jun 7, 2023

k8s-1.26-kernel-net-next failed due to #25958, unrelated. This looks ready to merge?

@rastislavs
Copy link
Contributor Author

k8s-1.26-kernel-net-next failed due to #25958, unrelated. This looks ready to merge?

yes, ready to merge

@rastislavs rastislavs added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 7, 2023
@dylandreimerink dylandreimerink merged commit b302f77 into cilium:main Jun 7, 2023
63 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bgp area/CI Continuous Integration testing issue or flake ci/flake This is a known failure that occurs in the tree. Please investigate me! ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Runtime Test (privileged) - Test_NeighborAddDel
4 participants