Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s: fix ciliumpodippools CRD controller-gen version #25976

Merged

Conversation

mhofstetter
Copy link
Member

@mhofstetter mhofstetter commented Jun 7, 2023

This commit fixes the outdated version in the annotation controller-gen.kubebuilder.io/version of the CRD ciliumpodippools by updating it to v0.11.4.

Fixes: #25974

@mhofstetter mhofstetter added the release-note/misc This PR makes changes that have no direct user impact. label Jun 7, 2023
@mhofstetter mhofstetter requested a review from a team as a code owner June 7, 2023 10:06
@mhofstetter mhofstetter added the sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. label Jun 7, 2023
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/fix-ippool-crd branch from 5598272 to 8231a09 Compare June 7, 2023 10:09
@mhofstetter mhofstetter changed the title k8s: fix ciliumpodippools controller-gen version k8s: fix ciliumpodippools CRD controller-gen version Jun 7, 2023
@mhofstetter
Copy link
Member Author

/test

Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🚀

@mhofstetter mhofstetter removed the request for review from youngnick June 7, 2023 11:34
@mhofstetter
Copy link
Member Author

removed review-request from @youngnick - as sig-k8s is already covered by @sayboras

This commit fixes the outdated version in the annotation
`controller-gen.kubebuilder.io/version` of the CRD ciliumpodippools
by updating it to `v0.11.4`.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@qmonnet
Copy link
Member

qmonnet commented Jun 7, 2023

/test

@gandro
Copy link
Member

gandro commented Jun 7, 2023

Go-related checks / generate-k8s-api (pull_request) is green 🟢

Let's not wait on CI to finish, since this prevents other PRs from becoming green.

@gandro gandro added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 7, 2023
@dylandreimerink dylandreimerink merged commit 41a48c5 into cilium:main Jun 7, 2023
57 of 63 checks passed
@mhofstetter mhofstetter deleted the pr/mhofstetter/fix-ippool-crd branch June 7, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: generate-k8s-api (check)
6 participants