Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI test resources unique for retries. #25990

Merged
merged 1 commit into from Jun 28, 2023
Merged

Conversation

viktor-kurchenko
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko commented Jun 7, 2023

Sometimes resources cleanup for CI tests might fail (due to the different reasons).
Then user won't be able to retry a pipeline till Custodian drops the provisioned resources.

Current PR adds pipeline retry counter to the resource names to avoid conflicts.

Workflows run results:
conformance-aks-v1.12.yaml
conformance-aks-v1.13.yaml
conformance-aws-cni-v1.11.yaml Cilium installation failed, not related to these changes
conformance-aws-cni-v1.12.yaml Cilium installation failed, not related to these changes
conformance-aws-cni-v1.13.yaml
conformance-aws-cni.yaml
conformance-clustermesh-v1.11.yaml
conformance-clustermesh-v1.12.yaml
conformance-clustermesh-v1.13.yaml
conformance-eks-v1.11.yaml
conformance-eks-v1.12.yaml
conformance-eks-v1.13.yaml
conformance-eks.yaml
conformance-externalworkloads-v1.11.yaml
conformance-externalworkloads-v1.12.yaml
conformance-externalworkloads-v1.13.yaml
conformance-externalworkloads.yaml
conformance-gke-v1.11.yaml
conformance-gke-v1.12.yaml
conformance-gke-v1.13.yaml
conformance-gke.yaml
conformance-multicluster-v1.11.yaml
conformance-multicluster-v1.12.yaml
conformance-multicluster-v1.13.yaml

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 7, 2023
@viktor-kurchenko viktor-kurchenko marked this pull request as ready for review June 8, 2023 08:53
@viktor-kurchenko viktor-kurchenko requested review from a team as code owners June 8, 2023 08:53
@viktor-kurchenko viktor-kurchenko added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 12, 2023
@joestringer joestringer added the release-note/ci This PR makes changes to the CI. label Jun 14, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 14, 2023
@joestringer joestringer added dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Jun 14, 2023
@viktor-kurchenko viktor-kurchenko removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jun 15, 2023
Signed-off-by: viktor-kurchenko <69600804+viktor-kurchenko@users.noreply.github.com>
@viktor-kurchenko viktor-kurchenko added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 28, 2023
@borkmann borkmann merged commit aebe9d7 into main Jun 28, 2023
54 of 55 checks passed
@borkmann borkmann deleted the improve/ci-cluster-names branch June 28, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants