Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpv1: Set default IdleHoldTime after reset #26001

Merged
merged 1 commit into from Jun 9, 2023
Merged

bgpv1: Set default IdleHoldTime after reset #26001

merged 1 commit into from Jun 9, 2023

Conversation

harsimran-pabla
Copy link
Contributor

@harsimran-pabla harsimran-pabla commented Jun 7, 2023 •
edited

This change sets DefaultIdleHoldTimeAfterReset to 5s, so BGP session moves from idle to active state after reset. The default in gobgp is 30s, which is excessively long for the session to be re-established.

Session reset is performed on neighbor configuration changes, like timers.

Fixes: #25968

Set BGP IdleHoldTimeAfterReset to 5 seconds, session reset can happen on BGP peer configuration change.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 7, 2023
@harsimran-pabla harsimran-pabla added area/bgp release-note/misc This PR makes changes that have no direct user impact. labels Jun 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 7, 2023
@harsimran-pabla harsimran-pabla added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. and removed release-note/misc This PR makes changes that have no direct user impact. labels Jun 7, 2023
@harsimran-pabla harsimran-pabla marked this pull request as ready for review June 7, 2023 20:35
@harsimran-pabla harsimran-pabla requested a review from a team as a code owner June 7, 2023 20:35
@harsimran-pabla harsimran-pabla force-pushed the hpabla/bgp_idleHoldTimeAfterReset branch 2 times, most recently from bd07fb8 to 2801bb5 Compare June 7, 2023 20:56
@harsimran-pabla
Copy link
Contributor Author

/test

@harsimran-pabla harsimran-pabla force-pushed the hpabla/bgp_idleHoldTimeAfterReset branch from 2801bb5 to f742c8c Compare June 8, 2023 13:37
rastislavs
rastislavs approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harsimran-pabla
Copy link
Contributor Author

harsimran-pabla commented Jun 8, 2023 •
edited by maintainer-s-little-helper bot

/test

Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed:

Click to show.

Test Name

K8sUpdates Tests upgrade and downgrade from a Cilium stable image to master

Failure Output

FAIL: Unexpected missed tail call

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/616/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.26-kernel-net-next so I can create one.

Then please upload the Jenkins artifacts to that issue.

@harsimran-pabla
Copy link
Contributor Author

harsimran-pabla commented Jun 8, 2023 •
edited

CI hitting issue similar to #25964

15:14:17 STEP: Cilium is not ready yet: connectivity health is failing: Cluster connectivity is unhealthy on 'cilium-hf4sj': Exitcode: 1 
Err: exit status 1
Stdout:
 	 
Stderr:
 	 Defaulted container "cilium-agent" out of: cilium-agent, config (init), mount-cgroup (init), apply-sysctl-overwrites (init), mount-bpf-fs (init), wait-for-node-init (init), clean-cilium-state (init), install-cni-binaries (init)
	 Error: Cannot get status/probe: Put "http://%2Fvar%2Frun%2Fcilium%2Fhealth.sock/v1beta/status/probe": dial unix /var/run/cilium/health.sock: connect: no such file or directory
	 
	 command terminated with exit code 1

@harsimran-pabla
Copy link
Contributor Author

test-1.26-net-next failing with known issue : #24514

@harsimran-pabla
bgpv1: Set default IdleHoldTime after reset
84439c8 
This change sets DefaultIdleHoldTimeAfterReset to 5s, so BGP session move from idle
to active state after reset is performed. Default in gobgp is 30s, which
is excessively long for session to be re-established.

Session reset is performed on some types of neighbor configuration changes, like timers.

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
@harsimran-pabla harsimran-pabla force-pushed the hpabla/bgp_idleHoldTimeAfterReset branch from f742c8c to 84439c8 Compare June 8, 2023 18:48
@harsimran-pabla
Copy link
Contributor Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 8, 2023
@dylandreimerink dylandreimerink merged commit 714ec54 into cilium:main Jun 9, 2023
63 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rastislavs rastislavs rastislavs approved these changes

Assignees
No one assigned
Labels
area/bgp ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Runtime Test (privileged) - Test_NeighborAddDel
3 participants
@harsimran-pabla @rastislavs @dylandreimerink