job,test: Improved reliability of TestTimer_DoubleTrigger
#26022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylandreimerink
added
release-note/ci
ti-mo
approved these changes
Jun 8, 2023
There existed an edge case in this test which caused it to flake: ``` panic: close of closed channel goroutine 106 [running]: github.com/cilium/cilium/pkg/hive/job.TestTimer_DoubleTrigger.func1() /home/runner/work/cilium/cilium/pkg/hive/job/job_test.go:445 +0x1d ``` This commit moves the triggering of the timer to before the hive starts to ensure they are all processes before the timer has a chance to start consuming them. Also added a guard around the closing of the channel so we don't panic if the test were to fail for another reason. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
dylandreimerink
force-pushed
the
feature/job-fix-double-trigger-flake
branch
from
32a8c30
to
8352c44
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There existed an edge case in this test which caused it to flake:
This PR moves the triggering of the timer to before the hive starts to ensure they are all processes before the timer has a chance to start consuming them. Also added a guard around the closing of the channel so we don't panic if the test were to fail for another reason.