datapath/linux/ethtool: deflake TestIsVirtualDriver #26027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, TestIsVirtualDriver is getting a list of all currently present network interfaces and then iterates them to call IsVirtualDriver. This is brittle, given a network interface can disappear between the call to netlink.LinkList and the call to IsVirtualDriver, as happens e.g. when creating dummyN interfaces in tests that run parallel to TestIsVirtualDriver. This then leads to a flake in the test. The proper fix is to change TestIsVirtualDriver to create a veth pair inside a new netns (so the interface names don't clash existing ones) and then call IsVirtualDriver only on that one and expect it to return true, nil. That way we also better test its actual behavior. Fixes #25888 Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added
sig/datapath
|
/test |
|
ginkgo failure is #25964: https://github.com/cilium/cilium/actions/runs/5210617097/jobs/9405073916 |
aspsk
approved these changes
Jun 8, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, TestIsVirtualDriver is getting a list of all currently present network interfaces and then iterates them to call IsVirtualDriver. This is brittle, given a network interface can disappear between the call to netlink.LinkList and the call to IsVirtualDriver, as happens e.g. when creating dummyN interfaces in tests that run parallel to TestIsVirtualDriver. This then leads to a flake in the test.
The proper fix is to change TestIsVirtualDriver to create a veth pair inside a new netns (so the interface names don't clash existing ones) and then call IsVirtualDriver only on that one and expect it to return true, nil. That way we also better test its actual behavior.
Fixes #25888