Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docu: add section about envoy daemonset deployment #26033

Merged
merged 1 commit into from Jun 20, 2023
Merged

docu: add section about envoy daemonset deployment #26033

merged 1 commit into from Jun 20, 2023

Conversation

mhofstetter
Copy link
Member

@mhofstetter mhofstetter commented Jun 8, 2023 •
edited

This PR adds documentation for the new funcitonality to deploy the CIlium Envoy proxy as separate DaemonSet (#25081).

@mhofstetter mhofstetter added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. release-note/misc This PR makes changes that have no direct user impact. area/servicemesh GH issues or PRs regarding servicemesh labels Jun 8, 2023
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/envoy-docs branch 4 times, most recently from c70ffbb to 64e21f4 Compare June 8, 2023 15:55
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/envoy-docs branch 4 times, most recently from 0a72126 to a25587c Compare June 19, 2023 12:31
@mhofstetter mhofstetter marked this pull request as ready for review June 19, 2023 12:32
@mhofstetter mhofstetter requested review from a team as code owners June 19, 2023 12:32
@mhofstetter mhofstetter requested a review from qmonnet June 19, 2023 12:32
qmonnet
qmonnet requested changes Jun 19, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, with a few nits and questions. Thanks!

Documentation/security/network/proxy/envoy.rst Outdated Show resolved Hide resolved
Documentation/security/network/proxy/envoy.rst Outdated Show resolved Hide resolved
Documentation/security/network/proxy/envoy.rst Outdated Show resolved Hide resolved
Documentation/security/network/proxy/envoy.rst Show resolved Hide resolved
Documentation/security/network/proxy/envoy.rst Outdated Show resolved Hide resolved
Documentation/security/network/proxy/envoy.rst Outdated Show resolved Hide resolved
@mhofstetter
Copy link
Member Author

@qmonnet thanks for your review. the latest force-push addresses your feedback.

qmonnet
qmonnet approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, look good now 👍.

For next time: No need to @-mention me on every reply :)

@mhofstetter
docu: envoy daemonset
8a84c9a 
This commit adds the section "Deployment as DaemonSet" to the
"Envoy" page, which describes the new deployment mode.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter
Copy link
Member Author

Reviews are in. Marking as ready-to-merge given that this is a docs-only PR.

@mhofstetter mhofstetter added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 20, 2023
@borkmann borkmann merged commit 2f39f57 into cilium:main Jun 20, 2023
39 checks passed
@mhofstetter mhofstetter deleted the pr/mhofstetter/envoy-docs branch June 20, 2023 14:57
@joestringer joestringer mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrajahalme jrajahalme jrajahalme approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. area/servicemesh GH issues or PRs regarding servicemesh ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mhofstetter @jrajahalme @qmonnet @borkmann