docs: add documentation for Ginkgo-based GHA #26055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
area/documentation
aanm
force-pushed
the
pr/update-documentation-ginkgo-actions
branch
from
b213df8
to
30f046a
Compare
qmonnet
requested changes
Jun 9, 2023
There was a problem hiding this comment.
The PRs can be merged independently.
I'd rather have these YAML files merged in before referencing them in the docs, for my part.
Nice work! I've got some comments below. Mostly minor items, however one concern is that we could probably integrate the new section for e2e tests better. I'd probably feel lost landing on the new version of the page if I were trying to get started with e2e tests, see more comments below.
Direct links to preview:
aanm
force-pushed
the
pr/update-documentation-ginkgo-actions
branch
from
30f046a
to
7670fb9
Compare
aanm
force-pushed
the
pr/update-documentation-ginkgo-actions
branch
3 times, most recently
from
c873253
to
fb1eae9
Compare
qmonnet
approved these changes
Jun 12, 2023
This commit adds comprehensive documentation on how to use GitHub Actions for Ginkgo Workflows, how to run tests locally, and test a particular SHA using GitHub. Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/update-documentation-ginkgo-actions
branch
from
fb1eae9
to
b112828
Compare
nebril
approved these changes
Jun 12, 2023
|
I note that #26019 has been merged, so we're good to go about referencing the new YAML files. |
nbusseneau
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds comprehensive documentation on how to use GitHub Actions for Ginkgo Workflows, how to run tests locally, and test a particular SHA using GitHub.
The docs were written on top of #26019. The PRs can be merged independently.