Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gateway-api: now function GatewayAPI also supports TLSRoute #26060

Merged
merged 1 commit into from Jun 9, 2023
Merged

gateway-api: now function GatewayAPI also supports TLSRoute #26060

merged 1 commit into from Jun 9, 2023

Conversation

spacewander
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

@spacewander
gateway-api: now function GatewayAPI also supports TLSRoute
e8836f0 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander requested a review from a team as a code owner June 9, 2023 06:20
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 9, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jun 9, 2023
@mhofstetter mhofstetter added the release-note/misc This PR makes changes that have no direct user impact. label Jun 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 9, 2023
mhofstetter
mhofstetter approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @spacewander thanks for keeping this up to date

@mhofstetter
Copy link
Member

mhofstetter commented Jun 9, 2023 •
edited

basic checks passed ✔️ marking as ready-to-merge as this is only changing a comment (not related to any generation)

@mhofstetter mhofstetter added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 9, 2023
@dylandreimerink dylandreimerink merged commit 001d28e into cilium:main Jun 9, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhofstetter mhofstetter mhofstetter approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spacewander @mhofstetter @dylandreimerink