docs: add upgrade note about deletion of stale entries in clustermesh #26067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
added
area/documentation
giorio94
force-pushed
the
mio/upgrade-notes
branch
from
9556b33
to
b7ae588
Compare
qmonnet
approved these changes
Jun 9, 2023
giorio94
requested review from
a team and
YutaroHayakawa
and removed request for
a team
Thanks for the heads up, I didn't notice that it hadn't worked. I've removed the review assignment and added it back, this time Yutaro got assigned. |
|
/test |
|
/test-runtime Hit unrelated flake: #23997 |
giorio94
force-pushed
the
mio/upgrade-notes
branch
from
b7ae588
to
df94c99
Compare
|
Rebased onto main to pick the fixes for conformance-ginkgo |
|
/test |
giorio94
added
the
release-blocker/1.14
|
/test-1.26-net-next Hit #24964 |
Closed
2 tasks
150de13 ("clustermesh: delete stale node/service entries on reconnect/disconnect"), along with the followup commits targeting ipcache entries and identities modified the cilium agents behavior to automatically clean up stale information after reconnecting to a given remote kvstore. This was needed to fix the issue described in cilium#24740. The behavior differs based on the remote version of the clustermesh-apiserver though. Indeed, newer versions support "sync canaries" to convey that the synchronization from k8s to the kvstore completed, while older ones don't. When sync canaries are not supported, the agents will trigger the deletion of stale entries once the corresponding etcd list operation completed: this might lead to the removal of valid entries if that information had not yet been synchronized from k8s to the kvstore, causing a temporary connectivity disruption (until that is then synchronized and propagated again to the agents). This commit extends the upgrade notes to detail this behavior and the implication. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
mio/upgrade-notes
branch
from
df94c99
to
c5890df
Compare
|
Rebased onto main to fix conflicts |
|
/test |
|
/ci-aks Hit #26075 |
YutaroHayakawa
requested review from
YutaroHayakawa
and removed request for
YutaroHayakawa
YutaroHayakawa
approved these changes
Jun 15, 2023
|
Reviews are in. Marking as ready to merge given that this is a docs-only PR, and the missing tests were skipped. |
giorio94
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#25499, along with the followups targeting ipcache entries (#25675) and identities (#25677) modified the cilium agents behavior to automatically clean up stale information after reconnecting to a given remote kvstore. This was needed to fix the issue described in #24740.
The behavior differs based on the remote version of the clustermesh-apiserver though. Indeed, newer versions support "sync canaries" to convey that the synchronization from k8s to the kvstore completed, while older ones don't. When sync canaries are not supported, the agents will trigger the deletion of stale entries once the corresponding etcd list operation completed: this might lead to the removal of valid entries if that information had not yet been synchronized from k8s to the kvstore, causing a temporary connectivity disruption (until that is then synchronized and propagated again to the agents). This commit extends the upgrade notes to detail this behavior and the implication.