clustermesh-apiserver: add missing metrics and documentation #26070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
added
area/documentation
|
Integration tests hit unrelated flake: #24904. Rerunning manually. |
|
/test |
nathanjsweet
approved these changes
Jun 9, 2023
This was referenced Jun 12, 2023
|
The last commit enables the goroutine sched latency metric in the clustermesh-apiserver, for consistency with the ones exposed by the agents: #26083 (comment) |
|
/test |
|
/ci-awscni Failed while checking out the code due to GH rate limiting: #26111 |
|
/ci-ginkgo Rerun to pick the fix for the matrix generation |
giorio94
changed the title
|
The last commit exposes the |
|
/test |
This was referenced Jun 13, 2023
giorio94
force-pushed
the
mio/clustermesh-apiserver-missing-metric
branch
from
fff20f4
to
1104157
Compare
|
Rebased onto main to pick the fixes for conformance-ginkgo |
|
/test |
The "processed requests" metric had been overlooked when selecting the list of rate limiter related metrics to expose by the clustermesh-apiserver. Hence, let's enable it now. Additionally, let's drop the one about the adjustment factor since auto adjustment is disabled. Fixes: 7908f20 ("etcd: add max inflight requests to rate limiter") Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
This commit extends the documentation with information about clustermesh-apiserver metrics that have been overlooked in previous commits. In particular, it mentions the new metrics in the upgrade guide, and lists the metrics concerning rate limiting in the reference table. Fixes: 7e65ca1 ("docs: add clustermesh-apiserver metrics") Fixes: 7908f20 ("etcd: add max inflight requests to rate limiter") Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Let's enable these optional metrics for consistency with the ones enabled in the cilium agent. They allow to troubleshoot strange behaviors in severely CPU constrained environments. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Let's expose the cilium_clustermesh_apiserver_version metric to convey information about the version of the clustermesh-apiserver. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
mio/clustermesh-apiserver-missing-metric
branch
from
1104157
to
6395a4c
Compare
|
Rebased onto main to fix conflicts |
|
/test |
|
/ci-aks Hit #26075 |
YutaroHayakawa
approved these changes
Jun 15, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the documentation with information about clustermesh-apiserver metrics that have been overlooked in previous commits. It also corrects the selection of the rate limiter metrics exposed by the clustermesh-apiserver and adds a couple of missing metrics.