metrics,endpointmanager: Register endpointmanager metrics via dependency #26078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylandreimerink
added
the
release-note/misc
dylandreimerink
force-pushed
the
feature/metrics-remove-must-register
branch
from
2e35484
to
50c519d
Compare
|
/test |
|
/test-1.25-4.19 |
|
/test-1.26-net-next |
chancez
approved these changes
Jun 13, 2023
pippolo84
reviewed
Jun 14, 2023
dylandreimerink
force-pushed
the
feature/metrics-remove-must-register
branch
from
50c519d
to
714f780
Compare
aditighag
approved these changes
Jun 16, 2023
dylandreimerink
added
the
dont-merge/wait-until-release
joestringer
removed
the
dont-merge/wait-until-release
The endpointmanager was the last package to use the MustRegister package scope function in metrics. This commit replaces the access via global function by providing the registry via dependency injection. This allows us to get rid of the metrics.MustRegister function. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
dylandreimerink
force-pushed
the
feature/metrics-remove-must-register
branch
from
714f780
to
f5a17b8
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The endpointmanager was the last package to use the MustRegister package scope function in metrics. This PR replaces the access via global function by providing the registry via dependency injection. This allows us to get rid of the metrics.MustRegister function.