Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS CNI v1.12 Cilium install fixed. #26084

Merged
merged 1 commit into from Jun 15, 2023
Merged

AWS CNI v1.12 Cilium install fixed. #26084

merged 1 commit into from Jun 15, 2023

Conversation

viktor-kurchenko
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko commented Jun 9, 2023 •
edited

Cilium installation for conformance-aws-cni-v1.12 workflow fixed.
Example of successful Cilium installation: https://github.com/cilium/cilium/actions/runs/5223819581/jobs/9431222838?pr=26084

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 9, 2023
@viktor-kurchenko
AWS CNI v1.12 Cilium install fixed.
822a9db 
Signed-off-by: viktor-kurchenko <69600804+viktor-kurchenko@users.noreply.github.com>
@viktor-kurchenko viktor-kurchenko marked this pull request as ready for review June 9, 2023 16:25
@viktor-kurchenko viktor-kurchenko requested review from a team as code owners June 9, 2023 16:25
brlbil
brlbil approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@brlbil brlbil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@viktor-kurchenko
Copy link
Contributor Author

Nice catch!

Thank you @brlbil
Unfortunately, AWS CNI 1.11 is also affected by the same issue but I don't understand why... I checked Cilium helm charts and 1.11 doesn't have enabled sub-property.

@viktor-kurchenko viktor-kurchenko added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 15, 2023
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Jun 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 15, 2023
@aanm aanm merged commit 0b3d6d6 into main Jun 15, 2023
49 checks passed
@aanm aanm deleted the fix/aws-cni-workflow branch June 15, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brlbil brlbil brlbil approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@viktor-kurchenko @brlbil @aanm