Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: misc CT cleanups #26104

Merged
merged 3 commits into from Jun 13, 2023
Merged

bpf: misc CT cleanups #26104

merged 3 commits into from Jun 13, 2023

Conversation

julianwiedmann
Copy link
Member

@julianwiedmann julianwiedmann commented Jun 12, 2023 •
edited

Some innocent cleanups from diving into the CT code recently.

@julianwiedmann
bpf: ct: remove NULL check in __ct_lookup()
66e0c71 
It's safe to remove this check, none of the callers passes a NULL ct_state.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
bpf: ct: make ACTION_* an enum
d2bc7d9 
Clarify what kind of value gets passed around.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
bpf: ct: clean up handling of ACTION_CREATE
fbce14c 
The magic bit operations make things unnecessarily difficult.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Jun 12, 2023
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann changed the title 1.14 bpf ct cleanups bpf: misc CT cleanups Jun 13, 2023
@julianwiedmann julianwiedmann marked this pull request as ready for review June 13, 2023 05:59
@julianwiedmann julianwiedmann requested a review from a team as a code owner June 13, 2023 05:59
aspsk
aspsk approved these changes Jun 13, 2023
View reviewed changes
bpf/lib/conntrack.h Show resolved Hide resolved
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 13, 2023
@julianwiedmann
Copy link
Member Author

ci-gingko fail is #25964

@julianwiedmann julianwiedmann merged commit e70dbad into cilium:main Jun 13, 2023
64 of 65 checks passed
@julianwiedmann julianwiedmann deleted the 1.14-bpf-ct-cleanups branch June 13, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspsk aspsk aspsk approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julianwiedmann @aspsk