New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kvstoremesh Dockerfile and build images through the CI #26106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
added
area/clustermesh
Relates to multi-cluster routing functionality in Cilium.
release-note/misc
This PR makes changes that have no direct user impact.
area/build
Anything to do with the build, more general then area/CI
dont-merge/blocked
Another PR must be merged before this one.
labels
Jun 12, 2023
aanm
approved these changes
Jun 12, 2023
squeed
approved these changes
Jun 12, 2023
giorio94
force-pushed
the
mio/kvstoremesh-build-artifacts
branch
from
June 12, 2023 12:19
bfbe532
to
d4c96fb
Compare
Force-pushed to drop the changes to install/kubernetes/Makefile.values, which belong to #26109. |
giorio94
added
the
release-blocker/1.14
This issue will prevent the release of the next version of Cilium.
label
Jun 12, 2023
nbusseneau
approved these changes
Jun 12, 2023
borkmann
approved these changes
Jun 13, 2023
joestringer
added
the
kind/enhancement
This would improve or streamline existing functionality.
label
Jun 14, 2023
This commit introduces the Dockerfile to build the kvstoremesh container (inspired from the clustermesh-apiserver one), and adapts the existing makefile targets to additionally build that container. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
mio/kvstoremesh-build-artifacts
branch
from
June 15, 2023 06:54
d4c96fb
to
47e2646
Compare
Rebased onto main now that #26083 has been merged |
/test |
giorio94
removed
the
dont-merge/blocked
Another PR must be merged before this one.
label
Jun 15, 2023
/ci-aks |
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/build
Anything to do with the build, more general then area/CI
area/clustermesh
Relates to multi-cluster routing functionality in Cilium.
kind/enhancement
This would improve or streamline existing functionality.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-blocker/1.14
This issue will prevent the release of the next version of Cilium.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup of #26083, which introduces the Dockerfile for kvstoremesh and adds kvstoremesh to the list of images built through the GitHub actions.