Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kvstoremesh Dockerfile and build images through the CI #26106

Merged
merged 2 commits into from Jun 15, 2023

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Jun 12, 2023

This PR is a followup of #26083, which introduces the Dockerfile for kvstoremesh and adds kvstoremesh to the list of images built through the GitHub actions.

@giorio94 giorio94 added area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/misc This PR makes changes that have no direct user impact. area/build Anything to do with the build, more general then area/CI dont-merge/blocked Another PR must be merged before this one. labels Jun 12, 2023
@giorio94 giorio94 requested review from a team as code owners June 12, 2023 09:02
@giorio94 giorio94 force-pushed the mio/kvstoremesh-build-artifacts branch from bfbe532 to d4c96fb Compare June 12, 2023 12:19
@giorio94
Copy link
Member Author

Force-pushed to drop the changes to install/kubernetes/Makefile.values, which belong to #26109.

@giorio94 giorio94 added the release-blocker/1.14 This issue will prevent the release of the next version of Cilium. label Jun 12, 2023
@joestringer joestringer added the kind/enhancement This would improve or streamline existing functionality. label Jun 14, 2023
This commit introduces the Dockerfile to build the kvstoremesh container
(inspired from the clustermesh-apiserver one), and adapts the existing
makefile targets to additionally build that container.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 force-pushed the mio/kvstoremesh-build-artifacts branch from d4c96fb to 47e2646 Compare June 15, 2023 06:54
@giorio94
Copy link
Member Author

Rebased onto main now that #26083 has been merged

@giorio94
Copy link
Member Author

/test

@giorio94 giorio94 removed the dont-merge/blocked Another PR must be merged before this one. label Jun 15, 2023
@giorio94
Copy link
Member Author

/ci-aks

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 15, 2023
@aanm aanm merged commit a07b305 into cilium:main Jun 15, 2023
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Anything to do with the build, more general then area/CI area/clustermesh Relates to multi-cluster routing functionality in Cilium. kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-blocker/1.14 This issue will prevent the release of the next version of Cilium. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants