Helm: add configuration options for kvstoremesh #26109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
added
release-note/minor
giorio94
commented
Jun 12, 2023
| @@ -2630,6 +2630,46 @@ clustermesh: | |||
| # cpu: 100m | |||
| # memory: 100Mi | |||
|
|
|||
| kvstoremesh: | |||
There was a problem hiding this comment.
The kvstoremesh configuration options are currently placed at this level for consistency with etcd, but I'm wondering whether they should be moved one level up. WDYT?
giorio94
force-pushed
the
mio/kvstoremesh-helm
branch
from
c2fb235
to
2beef43
Compare
squeed
reviewed
Jun 12, 2023
squeed
approved these changes
Jun 12, 2023
giorio94
force-pushed
the
mio/kvstoremesh-helm
branch
from
2beef43
to
4d20333
Compare
giorio94
added
the
release-blocker/1.14
tommyp1ckles
approved these changes
Jun 13, 2023
| # -- KVStoreMesh image. | ||
| image: | ||
| override: ~ | ||
| repository: "quay.io/cilium/kvstoremesh-ci" |
There was a problem hiding this comment.
this appears to be a CI image, is that intended?
There was a problem hiding this comment.
I've double-checked, and also the repositories for the other components point to CI images. It seems that they are sourced from here (and RELEASE is not set by default).
giorio94
force-pushed
the
mio/kvstoremesh-helm
branch
from
4d20333
to
69a0291
Compare
|
/test |
|
/ci-aks Failed due to #26075 |
giorio94
force-pushed
the
mio/kvstoremesh-helm
branch
from
69a0291
to
7b49c76
Compare
|
Force-pushed to explicitly set the etcd rate limit settings for kvstoremesh. |
|
/test |
joestringer
added
the
kind/enhancement
giorio94
force-pushed
the
mio/kvstoremesh-helm
branch
from
7b49c76
to
a87b374
Compare
|
Rebased onto main now that #26083 has been merged |
giorio94
removed
the
dont-merge/blocked
giorio94
force-pushed
the
mio/kvstoremesh-helm
branch
from
a87b374
to
49bc57a
Compare
|
/test |
aditighag
approved these changes
Jun 16, 2023
zacharysarah
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
@giorio94 Good work. Approving to unblock with the understanding that changes are required prior to merge.
maintainer-s-little-helper
bot
added
the
ready-to-merge
giorio94
added
dont-merge/bad-bot
Add the `clustermesh-apiserver.{namespace}.svc` DNS name to the
clustermesh-apiserver etcd certificate, so that the secure
connection can be successfully established when connecting to the
local etcd instance through the service, rather than to a remote one
through the corresponding LB/NodePort service or an external DNS name.
This is required in particular in the kvstoremesh case.
Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
The clustermesh-apiserver runs in pod network, hence there's no shortcoming in enabling those metrics by default. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
This commit extends the helm chart to allow configuring kvstoremesh. In particular, the clustermesh-apiserver deployment is enriched with the additional kvstoremesh sidecar container (when kvstoremesh is enabled), appropriately mounting the secret containing the remote kvstore configurations. Additionally, the configuration used by the agents is modified to connect to the local kvstore instance (through the corresponding service) instead of the remote ones. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
mio/kvstoremesh-helm
branch
from
49bc57a
to
2b7ada8
Compare
|
/test |
giorio94
removed
the
dont-merge/bad-bot
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup of #26083, which extends the helm chart to allow configuring kvstoremesh.