test/k8s: make kafka tests more reliable #26121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
the
release-note/misc
|
/test |
tklauser
approved these changes
Jun 12, 2023
jrajahalme
requested changes
Jun 13, 2023
test/k8s/kafka_policies.go
Outdated
| waitUntilSucceed := func(pod, arg, description string) { | ||
| var errBody error | ||
| body := func() bool { | ||
| errBody = kubectl.ExecKafkaPodCmd(helpers.DefaultNamespace, pod, prodHqAnnounce) |
There was a problem hiding this comment.
Should use arg in exec instead of prodHqAnnounce!
|
/test |
|
/ci-ginkgo |
|
/ci-ginkgo |
Waiting until the Kafka command succeeds will prevent any flakiness in the tests. Signed-off-by: André Martins <andre@cilium.io>
|
/ci-ginkgo |
jrajahalme
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting until the Kafka command succeeds will prevent any flakiness in the tests.
Fixes #26009
Tested locally plenty of times.