clustermesh: Introduce ClusterID reservation mechanism #26124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
marseel
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
giorio94
added
the
area/clustermesh
giorio94
reviewed
Jun 13, 2023
giorio94
reviewed
Jun 15, 2023
marseel
force-pushed
the
various_clustermesh_improvements
branch
2 times, most recently
from
9f40c4e
to
a97d1c0
Compare
|
/test |
marseel
force-pushed
the
various_clustermesh_improvements
branch
5 times, most recently
from
91e9ebf
to
03641a9
Compare
marseel
changed the title
|
/test |
|
/ci-multicluster Similar flake to #25816 |
giorio94
reviewed
Jun 16, 2023
Currently, the ClusterIDs for each remoteClusters are managed by each remote cluster controllers with rc.config. This makes very hard to control the access to the ClusterIDs. For example, when we have a new remote cluster connection and receive a new cluster config, we need to ensure the new ClusterID is not used by other remote cluster controller. To ensure that, we need to iterate over all remoteCluster objects and also access to the rc.config which may be changed over time depending on each remote cluster's connection state. For every time the remoteCluster controller start to use a new ClusterID, it "reserves" the ClusterID from central registry. By correctly performing mutex for this reservation, we can guarantee that no one else uses the reserved ClusterID. So that after the reservation, each remoteCluster controller can exclusively access to the corresponding CT/SNAT per-cluster map slots. This can also replace the complicated canConnect() validation with ClusterID reservation. Instead of iterate over all clusters and check ClusterID uniqueness, we can simply try to reserve the ID and if it fails, reject a new connection. Once the remote cluster controller finish using the ClusterID, it cleanups any resources bounded to the ClusterID (e.g. per-cluster maps) and "releases" the ClusterID. Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
marseel
force-pushed
the
various_clustermesh_improvements
branch
from
03641a9
to
743b9d0
Compare
|
/test |
marseel
added
release-note/misc
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
I'm going to merge this, but I will note that "reservation system" to me implies that there should be full lifecycle tests that allocate reservations and also ensure that reservations are properly garbage collected and so on. At a glance, I didn't see that sort of testing, so if we don't have any such testing then I would encourage you to think about building additional testing for those cases. |
|
This was mostly refactoring of existing code and not really introducing any new functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the lifecycle of cluster config by introducing the ClusterID reservation mechanism. More details in commit message