IPAM multipool followups #26138
Merged
IPAM multipool followups #26138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
release-note/misc
tklauser
force-pushed
the
pr/tklauser/ipam-allocator-create
branch
2 times, most recently
from
030c165
to
f3dd593
Compare
tklauser
force-pushed
the
pr/tklauser/ipam-allocator-create
branch
from
f3dd593
to
3095ce1
Compare
|
/test |
tklauser
force-pushed
the
pr/tklauser/ipam-allocator-create
branch
from
3095ce1
to
2cb4d05
Compare
|
/test Job 'Cilium-PR-K8s-1.26-kernel-net-next' hit: #25958 (92.28% similarity) |
|
/test-1.26-net-next |
tklauser
force-pushed
the
pr/tklauser/ipam-allocator-create
branch
from
2cb4d05
to
fcfa2a5
Compare
|
Rebased to pull in fixes for the failing kafka tests (#26009) |
|
/test |
doniacld
reviewed
Jun 14, 2023
doniacld
reviewed
Jun 14, 2023
doniacld
reviewed
Jun 14, 2023
NodeEventHandler.Create already calls NodeEventHandler.Update in all existing implementations. Thus, remove the Create method and rename Update to Upsert which more clearly describes its purpose. Also remove the unused (*Node).Update method instead of converting it to call NodeEventHandler.Upsert. It's never called anywhere and not needed to satisfy an interface. Signed-off-by: Tobias Klauser <tobias@cilium.io>
|
Only nits! I like how you 🧹 and simplified the code! 👏🏽 |
doniacld
approved these changes
Jun 14, 2023
Signed-off-by: Tobias Klauser <tobias@cilium.io>
ip.PrefixToIPNet implements the same functionality as the netipx.PrefixIPNet function in the go4.org/netipx dependency that is already vendored. Use it instead of maintaining our own copy. Signed-off-by: Tobias Klauser <tobias@cilium.io>
In (*PoolAllocator).updateCIDRSets the CIDRs are currently parsed twice, once using netip.ParsePrefix and once using net.ParseCIDR. Avoid this and pass the CIDRs as []netip.Prefix and at the same time also convert downstream functions in ipam/cidrset to take a netip.Prefix instead of *net.IPNet. Ref. cilium#25824 (comment) Ref. cilium#25991 (comment) Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/tklauser/ipam-allocator-create
branch
from
fcfa2a5
to
250e80c
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address various review comments and possible cleanups from the IPAM multipool PRs #22762 #25824 and #25991.
Review per commit.