Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf: test: fix pktgen for IPv6 NEXTHDR_DEST option #26151

Merged
merged 1 commit into from Jun 13, 2023

Conversation

julianwiedmann
Copy link
Member

When building packets with multiple IPv6 options, a missing break for the NEXTHDR_DEST option would cause us to set up the preceding option's nexthdr field incorrectly.

When building packets with multiple IPv6 options, a missing `break` for
the NEXTHDR_DEST option would cause us to set up the preceding option's
`nexthdr` field incorrectly.

Reported-by: Quentin Monnet <quentin@isovalent.com>
Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added kind/bug/CI This is a bug in the testing code. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/ci This PR makes changes to the CI. labels Jun 13, 2023
@julianwiedmann julianwiedmann requested a review from a team as a code owner June 13, 2023 06:15
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@julianwiedmann
Copy link
Member Author

This only touches the BPF unit tests, no need for full e2e coverage.

@julianwiedmann julianwiedmann added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 13, 2023
@borkmann borkmann merged commit 9a64111 into cilium:main Jun 13, 2023
51 checks passed
@julianwiedmann julianwiedmann deleted the 1.14-bpf-test-next-dest branch June 13, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug/CI This is a bug in the testing code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants