Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix neighbor test flakes #26156

Merged
merged 4 commits into from Jun 13, 2023
Merged

Fix neighbor test flakes #26156

merged 4 commits into from Jun 13, 2023

Conversation

borkmann
Copy link
Member

@borkmann borkmann commented Jun 13, 2023 •
edited

Fixes: #22373

@borkmann borkmann added area/CI Continuous Integration testing issue or flake sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Jun 13, 2023
@borkmann borkmann requested a review from a team as a code owner June 13, 2023 07:56
@borkmann borkmann requested a review from aspsk June 13, 2023 07:56
@borkmann
neigh, test: Bump the number of mcast solicitation messages
654e57b 
Bump the maximum number of attempts to resolve an address by multicast/broadcast
before marking the entry as unreachable. Defaults to 3, and we bump to 6 as in
CI it has been observed to be flaky in some test.

Fixes: #22373
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann
neigh, test: Move sysctl settings to constants
e7fffe2 
Make baseTime and mcastNum constants to avoid hard-coding in several
locations.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann
neigh, test: Bump time for new hwaddr to resolve
9b21d1c 
The TestArpPingHandling can fail sometimes when it waits for the new
hwaddress to propagate where it will hit the timeout. Bump it as the
time limit is too little to always converge.

Fixes: #22373
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann
neigh, test: Reenable TestArpPingHandling and TestArpPingHandlingForM…
46a2fac 
…ultiDevice

Revert the following commits to reenable the tests:

  - 6c552a9 ("pkg/datapath: skip TestArpPingHandling due flakiness")
  - 5a12f19 ("pkg/datapath: skip TestArpPingHandlingForMultiDevice due flakiness")

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann borkmann requested a review from ti-mo June 13, 2023 08:03
@borkmann
Copy link
Member Author

/test

aspsk
aspsk approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@aspsk aspsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 is the charm!

@aanm aanm merged commit 2a7c53a into main Jun 13, 2023
64 of 66 checks passed
@aanm aanm deleted the pr/neigh-tests branch June 13, 2023 14:11
@borkmann borkmann mentioned this pull request Jun 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-mo ti-mo ti-mo approved these changes

@aspsk aspsk aspsk approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: TestArpPingHandlingForMultiDevice gets stuck due to race
4 participants
@borkmann @ti-mo @aspsk @aanm