Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: provide the global services metric through the hive #26157

Merged
merged 1 commit into from Jun 16, 2023
Merged

metrics: provide the global services metric through the hive #26157

merged 1 commit into from Jun 16, 2023

Conversation

giorio94
Copy link
Member

This PR extracts the initialization of the global services metric from the global service cache constructor, providing it through cell.Metric and propagating it as appropriate.

@giorio94
metrics: provide the global services metric through the hive
70a2c7a 
This commit extracts the initialization of the global services metric
from the global service cache constructor, providing it through
`cell.Metric` and propagating it as appropriate.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 added kind/cleanup This includes no functional changes. area/metrics Impacts statistics / metrics gathering, eg via Prometheus. area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/misc This PR makes changes that have no direct user impact. labels Jun 13, 2023
@giorio94 giorio94 requested a review from a team as a code owner June 13, 2023 08:34
@giorio94
Copy link
Member Author

/test

@giorio94
Copy link
Member Author

One of the Conformance ginkgo matrix entries hit #26012. Manually rerun

This was referenced Jun 13, 2023
Closed
Closed
@giorio94
Copy link
Member Author

/test-runtime

@giorio94
Copy link
Member Author

giorio94 commented Jun 13, 2023 •
edited

/test-runtime

Hit #26150

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 16, 2023
@joestringer joestringer merged commit be2cb2b into cilium:main Jun 16, 2023
66 checks passed
@julianwiedmann julianwiedmann mentioned this pull request Jun 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

Assignees
No one assigned
Labels
area/clustermesh Relates to multi-cluster routing functionality in Cilium. area/metrics Impacts statistics / metrics gathering, eg via Prometheus. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@giorio94 @YutaroHayakawa @joestringer