Improve Makefile to ease debugging #26159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pippolo84
added
release-note/misc
tklauser
approved these changes
Jun 14, 2023
|
Runtime test (privileged) failure tracked in #26233, rerunning |
This comment was marked as outdated.
This comment was marked as outdated.
The Dockerfile used to build the operator images uses fixed paths as destination and binary directories. The commit changes this to use the variables defined in Makefile.defs, just like in the agent Dockerfile. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
Add the ability to override Makefile variables using an additional Makefile.override file for debugging purposes. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
force-pushed
the
pr/pippolo84/Makefiles-Dockerfiles-improvement
branch
from
ac1304c
to
7824047
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Mar 20, 2024
Include Makefile.override if the file exists to allow overriding Make variables without modifying Makefile. Copied from cilium/cilium#26159. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Mar 21, 2024
- Include Makefile.override if the file exists to allow overriding Make variables without modifying Makefile. Copied from cilium/cilium#26159. - Define GO_BUILD_LDFLAGS to use with default and local-release targets so that these targets consistently use the same ldflags without having to update multiple places. It also makes it easier to override ldflags with Makefile.override. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
tklauser
pushed a commit
to cilium/cilium-cli
that referenced
this pull request
Mar 22, 2024
- Include Makefile.override if the file exists to allow overriding Make variables without modifying Makefile. Copied from cilium/cilium#26159. - Define GO_BUILD_LDFLAGS to use with default and local-release targets so that these targets consistently use the same ldflags without having to update multiple places. It also makes it easier to override ldflags with Makefile.override. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to override variables in Makefile for debugging purposes. This is done including (when available) an additional
Makefile.overridefile.Also, refactor the operator Dockerfile to remove fixed paths and rely on the ones defined in
Makefile.defs, just like we do for the agent Dockerfile.