jenkinsfiles: remove ginkgo-based Jenkinsfiles #26171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of Ginkgo-based CI on GitHub actions we will no longer rely on Jenkins to run the ginkgo-based tests for main branch. This commit removes the Jenkins files that are used to trigger the tests on the PRs. For reference, the most important commits that lead to the removal of the Jenkinsfiles: - 1b19e5f ("test: run runtime tests on GH actions") - a81ca1c ("test: run ginkgo tests on GH actions") - c2c5ed3 ("docs: add documentation for Ginkgo-based GHA") Signed-off-by: André Martins <andre@cilium.io>
aanm
added
area/CI
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
aanm
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
nebril
approved these changes
Jun 13, 2023
qmonnet
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Should the Conformance Ginkgo workflow be marked as required, first?
[EDIT: I suppose the issue is that we would no longer be able to skip it for Documentation-only PRs? -> Answered offline: no issue, because this workflow is triggered by comments, so we "manually" set the result in the workflow]
nbusseneau
approved these changes
Jun 14, 2023
tommyp1ckles
approved these changes
Jun 14, 2023
|
👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of Ginkgo-based CI on GitHub actions we will no longer rely on Jenkins to run the ginkgo-based tests for main branch.
This commit removes the Jenkins files that are used to trigger the tests on the PRs.
For reference, the most important commits that lead to the removal of the Jenkinsfiles:
Notes: