.github: add dedicated job to wait for images #26184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
area/CI
nbusseneau
approved these changes
Jun 13, 2023
|
/ci-ginkgo |
nbusseneau
requested changes
Jun 13, 2023
There was a problem hiding this comment.
We need to do the same for lines 310-317 https://github.com/cilium/cilium/pull/26184/files#diff-7b1c1cd100727d47983442d5c5860d86fa34ebac932ca2380db80cf369915cc6R310-R317
We can have a dedicated job that waits for images and it shouldn't be part of the build-ginkgo-binary workflow. Suggested-by: Nicolas Busseneau <nicolas@isovalent.com> Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/split-waiting-for-images-in-separate-job
branch
from
c5723c4
to
29a8cca
Compare
nbusseneau
approved these changes
Jun 13, 2023
brlbil
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can have a dedicated job that waits for images and it shouldn't be part of the build-ginkgo-binary workflow.
Suggested-by: Nicolas Busseneau nicolas@isovalent.com